SLua editor: multi-line strings and comments #3807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
along with missing meshoptimizer license
marchcat
changed the title
akleshchev
reviewed
Mar 31, 2025
akleshchev
reviewed
Mar 31, 2025
akleshchev
reviewed
Mar 31, 2025
| @@ -104,47 +104,42 @@ | |||
| <key>boolean</key> | |||
| <map> | |||
| <key>tooltip</key> | |||
| <string>Lua boolean: represents a true or false value.</string> | |||
| <string>Boolean: represents a true or false value.</string> | |||
There was a problem hiding this comment.
Should lua tooltips really be in app_settings? We need them to be localizable.
There was a problem hiding this comment.
We have a default LSL keywords file in the same location, so this is correct.
For LSL, we also receive one from the server, but that isn't supported for SLua yet.
There was a problem hiding this comment.
Default keyword for LSL updates from server, I'm not sure it's something that should be replicated for Lua.
There was a problem hiding this comment.
It's planned to be implemented later. For now we just use a placeholder class LLSyntaxLua.
akleshchev
approved these changes
Mar 31, 2025
maxim-productengine
approved these changes
Mar 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.