#3409 Make maximum probe count adjustable. #3709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geenz
force-pushed
the
geenz/reflection-probe-caps
branch
from
e894a3a to
4f35066
Compare
marchcat
approved these changes
Mar 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for being able to adjust the number of probes that can be used at once. This can have VRAM savings somewhere in the hundreds on low end machines, and GPU usage variances of around ~10% in testing on an RTX 3090 and Radeon RX 7900 XTX in my testing (1 probe on the low end up to the full 256 probes).