#3597 Fix crash when RenderDebugGLSession is True #3622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleshchev
approved these changes
Feb 27, 2025
maxim-productengine
approved these changes
Feb 27, 2025
Geenz
approved these changes
Feb 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash wasn't 100% reproducible, but I managed to catch it.
The problem is that
GL_BLEND_SRCandGL_BLEND_DSTare not valid parameters forglGetIntegerv()in modern OpenGL. So far, the only version where I see them referenced is 1.1.So, in order to check the values, we need to query the RGB and alpha factors separately. Using the old enums can cause the driver to return junk data, leading to the observed crash.