Skip to content

#3511 fix for PBR skies being too bright on Low Graphics #3570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

maxim-productengine
Copy link
Contributor

No description provided.

@Geenz
Copy link
Collaborator

Geenz commented Feb 17, 2025

@maxim-productengine The changes look mostly good - can I get a before and after on this including the specific sky you tested with this?

@maxim-productengine
Copy link
Contributor Author

Here's comparison before/after this change for 'Nacon's Planet Matricon' on Low quality.

before_

after_

But actually, same issue happened on few other Nacon's PBR environments.

@Geenz
Copy link
Collaborator

Geenz commented Feb 18, 2025

That looks right to me. Thank you! Feel free to merge when ready.

@maxim-productengine maxim-productengine merged commit 8114850 into release/2024.12-ForeverFPS Feb 18, 2025
11 checks passed
@maxim-productengine maxim-productengine deleted the maxim/ForeverFPS-3511 branch February 18, 2025 09:33
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
@maxim-productengine maxim-productengine linked an issue Feb 18, 2025 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PBR skies are too bright when using Low Graphics quality
3 participants