Skip to content

Add Analyze Compile Flags #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: archive/develop
Choose a base branch
from
Draft

Add Analyze Compile Flags #3387

wants to merge 1 commit into from

Conversation

AiraYumi
Copy link
Contributor

@AiraYumi AiraYumi commented Jan 9, 2025

Fixed version of #3321

@github-actions github-actions bot added the cmake label Jan 9, 2025
@marchcat marchcat requested a review from brad-linden January 10, 2025 16:33
@marchcat
Copy link
Contributor

Just checked, and it throws the same errors on my mac builds as before. Let's keep this one open until we fix the builds.

@AiraYumi
Copy link
Contributor Author

I can build it with the GHA build, but I don't know why an error occurs on the actual device.
I don't own a Mac, so I can't check the error.

@marchcat
Copy link
Contributor

Right, because GHA builds use "Release" configuration.

@marchcat
Copy link
Contributor

@AiraYumi, are your local linux builds fine with these changes and "ReleaseWithDebInfo" configuration? I don't have a linux dev setup right now, so can't verify that.

@AiraYumi
Copy link
Contributor Author

oops, Relwithdebinfoes options did not exist in the Linux version and an error occurred. You need to fix it.

@AiraYumi AiraYumi marked this pull request as draft January 10, 2025 22:40
@AiraYumi
Copy link
Contributor Author

Changed to Draft.
You need to fix all errors related to DEB

@AiraYumi
Copy link
Contributor Author

I think this is necessary.
e84a180

@marchcat
Copy link
Contributor

marchcat commented Jan 10, 2025 •
edited
Loading

Right, it will allow you to test this change as well.

@AiraYumi
Copy link
Contributor Author

AiraYumi commented Jan 11, 2025 •
edited
Loading

I checked. There were a lot of build errors caused by adding the debug option.
This will probably take a fair amount of time to fix. maybe.

https://github.com/AiraYumi/viewer/actions/runs/12720005335/job/35461069394

@AiraYumi
Copy link
Contributor Author

Can you merge this into a branch other than develop?
We expect a large number of CVE-related errors to occur, so we cannot determine the scale of the fix in a short time...

@AiraYumi
Copy link
Contributor Author

I built it with GCC_DISABLE_FATAL_WARNINGS enabled.
analyzer.log

@AiraYumi AiraYumi marked this pull request as ready for review January 15, 2025 13:44
@AiraYumi AiraYumi force-pushed the add_debinfo branch 2 times, most recently from 5457c3e to 3fae630 Compare January 23, 2025 01:24
@AiraYumi AiraYumi mentioned this pull request Jan 27, 2025
Open
@AiraYumi AiraYumi marked this pull request as draft February 18, 2025 03:55
@AiraYumi
Copy link
Contributor Author

Since the cause of the build error is unknown, we will change it to Draft for now.
We need to determine whether it is a problem with boost or not.

@AiraYumi
Copy link
Contributor Author

I contacted the boost team about the issue but got no response.
Upgrading from 1.86.0 will prevent 3p-boost from building.
I'm going to close this PR until it's resolved, but I'd like to hear your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brad-linden brad-linden Awaiting requested review from brad-linden

Assignees
No one assigned
Labels
cmake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AiraYumi @marchcat