Linux/GCC 13 build fix for template specialization of pasteTextWithLinebreaks #2729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all. Thus turn the specialization of pasteTextWithLinebreaks into a class methode pasteTextWithLinebreaksImpl.
|
Another GCC bug. This construct should be allowed as per C++17. GCC bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85282 |
Ansariel
reviewed
Sep 27, 2024
| @@ -313,10 +313,9 @@ class LLTextEditor : | |||
| template <typename STRINGTYPE> | |||
| void pasteTextWithLinebreaks(const STRINGTYPE& clean_string) | |||
| { | |||
| pasteTextWithLinebreaks<LLWString>(ll_convert(clean_string)); | |||
| pasteTextWithLinebreaksImpl(ll_convert(clean_string)); | |||
There was a problem hiding this comment.
What about
void pasteTextWithLinebreaks(const STRINGTYPE& clean_string)
{
if constexpr (std::is_same_v<LLWString, STRINGTYPE>)
pasteTextWithLinebreaksImpl(clean_string);
else
pasteTextWithLinebreaksImpl(ll_convert(clean_string));
}
to prevent an unnecessary ll_convert if not needed?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 13 did not like having a template<> inside the class body at all.
Thus turn the specialization of pasteTextWithLinebreaks into a class methode pasteTextWithLinebreaksImpl.