Fix various issues with snapshot upload fee calculation #2688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ansariel
commented
Sep 25, 2024
Ansariel
commented
- Removed orphaned LLPanelOutfitSnapshotInventory
- Calculation of upload in snapshot to inventory panel for insufficient funds was based on preview image size instead of encoded image size, resulting in upload fees of L$50 for textures <= 1024x1024 pixels
- Calculation on the options button had the same issue plus additionally was using referring to the previously used snapshot type which isn't necessarily the same as snapshot to inventory. Removed the upload fee from the button.
- Added back display of calculated upload fee on the snapshot to inventory panel itself. The fee is updated if the image size changes to always display the correct upload fee.
…ed image size and display upload cost to user
… based on previously selected snapshot type and not necessarily snapshot to inventory
…n is "Current Window" to determine correct image size and upload cost
Ansariel
force-pushed
the
develop-snapshot-fixes
branch
from
05dbe68 to
31e8a25
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.