Inventory favorites #1840
Inventory favorites #1840
Conversation
To not acuse confusion with favorites
image is WIP
notecards do not need to store 'favorite' flag
getChangedIDs is only accurate in scope of observer's callback, don't use it onIdle. getObject call made no sense, item was warrantied to be LLViewerInventoryItem and would only be AT_CATEGORY if it is a link, making the following cast to a category dangerous
For now marking originals, pointless to marks links in COF, needs a revision due to inconsistency with inventory
Search forces a refresh - can search items that don't exist yet Always notify parent of rect changes despite visibility (alterantively - rearrange on open)
|
It's already partially tested since QA had to use it to check server changes, and even if there are issues, impact should be minimal. |
indra/newview/llappearancemgr.cpp
Outdated
| @@ -2042,7 +2042,7 @@ bool LLAppearanceMgr::getCanReplaceCOF(const LLUUID& outfit_cat_id) | |||
| } | |||
|
|
|||
| // Moved from LLWearableList::ContextMenu for wider utility. | |||
| bool LLAppearanceMgr::canAddWearables(const uuid_vec_t& item_ids) const | |||
| bool LLAppearanceMgr::canAddWearables(const uuid_vec_t& item_ids, bool warn_on_type_mismarch) const | |||
There was a problem hiding this comment.
"mismarch" typo
| void LLFloaterInventorySettings::updateColorSwatch() | ||
| { | ||
| bool val = getChild<LLUICtrl>("favorites_color")->getEnabled(); | ||
| getChild<LLUICtrl>("favorites_color")->setEnabled(val); |
There was a problem hiding this comment.
Not sure what happens here.
There was a problem hiding this comment.
It should have been getvalue() then getChild("favorites_swatch")->setEnabled(val);
|
|
||
| if (obj && obj->getIsLinkType()) | ||
| { | ||
| obj = gInventory.getObject(obj_id); |
There was a problem hiding this comment.
Should we use 'obj->getLinkedUUID()' here as id?
| LLInventoryObject* obj = gInventory.getObject(obj_id); | ||
| if (obj && obj->getIsLinkType()) | ||
| { | ||
| obj = gInventory.getObject(obj_id); |
There was a problem hiding this comment.
Same question as above ('obj->getLinkedUUID()')
indra/newview/llinventoryfunctions.h
Outdated
| //~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| // Class LLFavoritesCollector | ||
| // | ||
| // Simple class that collects calling cards that are not null, and not |
There was a problem hiding this comment.
No more calling cards collectors.
|
Thank you! Will fix those. |
No description provided.