Skip to content

Linux viewer (ReleaseOS) resurrection #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 75 commits into from
Apr 5, 2024
Merged

Linux viewer (ReleaseOS) resurrection #1099

merged 75 commits into from
Apr 5, 2024

Conversation

@Nicky-D
Copy link
Contributor

@Nicky-D Nicky-D commented Mar 31, 2024 •
edited
Loading

This will (mostly) bring a buildable Linux viewer.

  • Update viewer to SDL2, as SDL1 is way too outdated
  • Update all other 3Ps to up to date version from LL's org
  • Remove fontconfig and rather use the system one
  • Update gstreamer plugin to gstreamer-1

There's still a few rough edges:

  • No CEF (was not working before either) (coming in another PR after this via dullahan / viewer
  • VRAM detection will not work (can be made to work, but again how to create a new repo in the LL org?)

Nicky-D added 30 commits December 29, 2023 19:45
@Nicky-D
Disable C++20 compat warnings for now (llcomon needs to be fixed for …
b827c3d 
…this one to work)
@Nicky-D
Remove GoogleMock and Tut cinlude, they are pulled in via LLAddBuildT…
5bc1173 
…est.cmake
@Nicky-D
bpp is deprecated in favor of prec
ea720a0
@Nicky-D
Initialize variable
fff2a91
@Nicky-D
Disable (in this case) overly picky GCC warnings
4fff949
@Nicky-D
Create custom functions to make GCC happy
4cb6fbe
@Nicky-D
Update packages for Linux
dffa634 
# Removed
- SDL1 (switch to system package of SDL2)
- fontconfig/freetype (switch to system packages)
- gtk/atk/pango/glib
  - glib > system packages
  - atk/gtk -> fltk system packages
# Add
  - meshoptimizer [^1]
  - mikktspace
# Update
  - apr
  - boost
  - colladadom
  - cubemaptoequirectangular [^1]
  - jpegencoderbasic [^1]
  - threejs [^1]
  - curl
  - libxml2
  - ogg vorbis
  - pcre

[^1]: Pending PR to get a Linden 3P URL
@Nicky-D
Adapt to new 3P pacakges, take SDL, glib, fltk, fontconfig, freetype …
acd0fba 
…as system libs
@Nicky-D
Make GCC happy with an explicit 0 comparison
ed61466
@Nicky-D
Do not compile any test logic or pull in any testing 3ps when testing…
16d3c87 
… is off.
@Nicky-D
First round of Linux adaption
8e58f41
@Nicky-D
U64 is not the same type as GLuint64
e6d31dd
@Nicky-D
te can never be zero (is a reference)
a9b0cad
@Nicky-D
Silence GCC warnings
9903b72
@Nicky-D
Compile without NDOF
38ebaa4
@Nicky-D
Update jsoncpp to a build that's actually 64 bits
65ad9de
@Nicky-D
- Remove boost signals (that lib is not part of the 3p)
7f9005d 
- Reorder libraries for correct linkinh
@Nicky-D
Update jsoncpp library name
053a8a2
@Nicky-D
Update meshoptimizer librarary name
4ad5199
@Nicky-D
Reorder libraries for correct linking
ed65b1e
@Nicky-D
Move away from deprecated DBUS
f823c25
@Nicky-D
Remove unused variable
0b16b3e
@Nicky-D
Remove bogus assignment to variable just defined
8532341
@Nicky-D
Remove unused variable
f36291d
@Nicky-D
bool is a bool, not 2 or 0
506cacb
@Nicky-D
- Make sure final binaries get an RPATH embedded
bcaf4ab 
- Use ccache if found
- Remove 32 bit smipped
- Add linker options via add_link_options rather than setting CMAKE variables
@Nicky-D
Get rid of ConfigurePkgConfig, this does more harm than good
4006d89
@Nicky-D
gstreamer10 plugin source drop
9207500
@Nicky-D
Why would indra/cmake/* end in .gitignore. That makes no sense at all
c205925
@Nicky-D
Add a first version of GLIB.cmake and GStreamer10Plugin.cmake.
28a2d8f 
Those are pulling in glib/gio/gstreamer from systemlibs.

- For gstreamer that is not too much of a problem. Only header files are used.
- GLIB/GIO are linked, but at least they are very stable APIs/ABIs
Nicky-D and others added 10 commits April 3, 2024 12:50
@Nicky-D
Disable a couple of warnings popping up on the GHA image. Those cases…
38023db 
… seem to be well guarded by a llassert_always and thus are unreachable
@Nicky-D
Fix some misleading indents GCC complains about (tabs vs spaces misma…
7829b07 
…tch_
@Nicky-D
Default initialize variables to squelch GCC warnings about -Wmaybe-un…
aa0031a 
…initialized.
@Nicky-D
Add -k0 to have a change to get all errors.
55a1f28
@Nicky-D
Better error handling
8788a3c
@Nicky-D
Make sure struct values get initialized
1e034ea
@Nicky-D
Disable warning due to unused _out.
c237aef 
The intent of that LL_DEBUGS seems unclear. I'd wager it does not log anything at all

error: statement has no effect [-Werror=unused-value]
  387 |                         _out
      |                         ^~~~
note: in expansion of macro ‘lllog_test_’
  381 |                 lllog_test_()
      |                 ^~~~~~~~~~~
note: in expansion of macro ‘lllog’
  429 | #define LL_DEBUGS(...)  lllog(LLError::LEVEL_DEBUG, false, ##__VA_ARGS__)
      |                         ^~~~~
note: in expansion of macro ‘LL_DEBUGS’
  830 |         LL_DEBUGS("LogViewerStatsPacket");
      |         ^~~~~~~~~
@Nicky-D
Make intent of "else if" more clear to the human reader
7a33aa2
@Nicky-D
small clang fix
66c5026
@AiraYumi
fix build for linux
8ced2e7
@AiraYumi AiraYumi mentioned this pull request Apr 3, 2024
Closed
Nicky-D added 2 commits April 3, 2024 16:24
@Nicky-D
FLTK's find module is weird, to work around this use find_library our…
8414132 
…selves and search the static lib.

The lib also needs a few more requirements. For future maybe it would be better to search them via cmake?
@Nicky-D
Name the action workflow accordingly
4f09adc
@Nicky-D
Copy link
Contributor Author

Nicky-D commented Apr 3, 2024

@marchcat / @bennettgoble / @nat-goodspeed
I did update this with the correct icu4c, freetype.
Created an example linux GHA yml and resolved all the errors. Resulting in a successful build (ReleaseOS) under my account.
The yml obviously needs some love (or to be pulled) as it serves just as a bare bones skeleton.
Otherwise IMO this is in a state that can be merged as a first step to build a viewer.
Everything else could be taken from there.

@Nicky-D Nicky-D changed the title Enable building a Linux viewer Linux viewer (ReleaseOS) resurrection Apr 3, 2024
marchcat
marchcat approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@marchcat marchcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nicky-D, thank you very much!

@marchcat
Copy link
Contributor

marchcat commented Apr 3, 2024

@bennettgoble, @nat-goodspeed,
any objections to merging this?

bennettgoble
bennettgoble approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@bennettgoble bennettgoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sans some nit picks. Once this is integrated we can consider rolling linux builds into the main ci.yaml file and discuss distribution strategy, next steps.

@marchcat
Copy link
Contributor

marchcat commented Apr 5, 2024

@Nicky-D, do you plan any more changes for this PR? I'll merge it if not.

@Nicky-D
Copy link
Contributor Author

Nicky-D commented Apr 5, 2024

@marchcat please merge it, this will give a baseline to base new PRs on

@marchcat marchcat merged commit 57d4237 into secondlife:release/maint-b Apr 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
@vir-linden vir-linden self-requested a review April 10, 2024 13:47
@Nicky-D Nicky-D deleted the feature/linux_build branch October 4, 2024 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marchcat marchcat marchcat approved these changes

@nat-goodspeed nat-goodspeed Awaiting requested review from nat-goodspeed

@vir-linden vir-linden Awaiting requested review from vir-linden

+2 more reviewers

@AiraYumi AiraYumi AiraYumi left review comments

@bennettgoble bennettgoble bennettgoble approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c/cpp cmake llcommon llcorehttp llimage llmath llmessage llprimitive llrender llwindow python

Projects

None yet

Milestone

Maintenance B

Development

Successfully merging this pull request may close these issues.

5 participants

@Nicky-D @marchcat @bennettgoble @vldevel @AiraYumi