Crash at LLWearableItemsList's ContextMenu

[sl-service-account]

BugSplat Crash Group 100868

View Report Group
View Report Details
View Report Attachments

Application: Second Life Release
Version: 7.2.1.16917391845
Error Code: c0000005 Access violation

Callstack:

Function	File
SecondLifeViewer!LLWearableItemsList::ContextMenu::updateItemsVisibility	C:/a/viewer/viewer/indra/newview/llwearableitemslist.cpp(997)
SecondLifeViewer!LLWearableItemsList::ContextMenu::createMenu	C:/a/viewer/viewer/indra/newview/llwearableitemslist.cpp(949)
SecondLifeViewer!LLListContextMenu::show	C:/a/viewer/viewer/indra/newview/lllistcontextmenu.cpp(76)
SecondLifeViewer!LLWearableItemsList::ContextMenu::show	C:/a/viewer/viewer/indra/newview/llwearableitemslist.cpp(870)
SecondLifeViewer!LLOutfitsList::onWearableItemsListRightClick	C:/a/viewer/viewer/indra/newview/lloutfitslist.cpp(720)
SecondLifeViewer!boost::_mfi::mf	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/bind/mem_fn.hpp(74)
SecondLifeViewer!boost::_bi::list,boost::arg<1>,boost::arg<2>,boost::arg<3> >::call_impl	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/bind/bind.hpp(192)
SecondLifeViewer!boost::_bi::list,boost::arg<1>,boost::arg<2>,boost::arg<3> >::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/bind/bind.hpp(208)
SecondLifeViewer!boost::_bi::bind_t	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/bind/bind.hpp(321)
SecondLifeViewer!boost::detail::function::void_function_obj_invoker	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/function/function_template.hpp(101)
SecondLifeViewer!boost::function_n::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/function/function_template.hpp(789)
SecondLifeViewer!boost::signals2::detail::call_with_tuple_args::m_invoke	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/detail/variadic_slot_invoker.hpp(105)
SecondLifeViewer!boost::signals2::detail::call_with_tuple_args::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/detail/variadic_slot_invoker.hpp(90)
SecondLifeViewer!boost::signals2::detail::variadic_slot_invoker::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/detail/variadic_slot_invoker.hpp(133)
SecondLifeViewer!boost::signals2::detail::slot_call_iterator_t,std::_List_iterator >,boost::signals2::slot	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/detail/slot_call_iterator.hpp(108)
SecondLifeViewer!boost::iterators::iterator_core_access::dereference	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/iterator/iterator_facade.hpp(631)
SecondLifeViewer!boost::iterators::detail::iterator_facade_base,std::_List_iterator >,boost::signals2::slot	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/iterator/iterator_facade.hpp(737)
SecondLifeViewer!boost::signals2::optional_last_value::operator(),std::_List_iterator >,boost::signals2::slot	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/optional_last_value.hpp(58)
SecondLifeViewer!boost::signals2::detail::combiner_invoker::operator()	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/detail/result_type_wrapper.hpp(64)
SecondLifeViewer!boost::signals2::detail::signal_impl	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/detail/signal_template.hpp(246)
SecondLifeViewer!boost::signals2::signal	C:/a/viewer/viewer/build-vc170-64/packages/include/boost/signals2/detail/signal_template.hpp(733)
SecondLifeViewer!LLUICtrl::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/lluictrl.cpp(392)
SecondLifeViewer!LLView::childrenHandleMouseEvent	C:/a/viewer/viewer/indra/llui/llview.cpp(767)
SecondLifeViewer!LLView::childrenHandleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1192)
SecondLifeViewer!LLView::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1138)
SecondLifeViewer!LLUICtrl::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/lluictrl.cpp(388)
SecondLifeViewer!LLView::childrenHandleMouseEvent	C:/a/viewer/viewer/indra/llui/llview.cpp(767)
SecondLifeViewer!LLView::childrenHandleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1192)
SecondLifeViewer!LLView::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1138)
SecondLifeViewer!LLUICtrl::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/lluictrl.cpp(388)
SecondLifeViewer!LLView::childrenHandleMouseEvent	C:/a/viewer/viewer/indra/llui/llview.cpp(767)
SecondLifeViewer!LLView::childrenHandleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1192)
SecondLifeViewer!LLView::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1138)
SecondLifeViewer!LLUICtrl::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/lluictrl.cpp(388)
SecondLifeViewer!LLView::childrenHandleMouseEvent	C:/a/viewer/viewer/indra/llui/llview.cpp(767)
SecondLifeViewer!LLView::childrenHandleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1192)
SecondLifeViewer!LLView::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1138)
SecondLifeViewer!LLUICtrl::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/lluictrl.cpp(388)
SecondLifeViewer!LLView::childrenHandleMouseEvent	C:/a/viewer/viewer/indra/llui/llview.cpp(767)
SecondLifeViewer!LLView::childrenHandleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1192)
SecondLifeViewer!LLView::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1138)
SecondLifeViewer!LLUICtrl::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/lluictrl.cpp(388)
SecondLifeViewer!LLView::childrenHandleMouseEvent	C:/a/viewer/viewer/indra/llui/llview.cpp(767)
SecondLifeViewer!LLView::childrenHandleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1192)
SecondLifeViewer!LLView::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1138)
SecondLifeViewer!LLUICtrl::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/lluictrl.cpp(388)
SecondLifeViewer!LLView::childrenHandleMouseEvent	C:/a/viewer/viewer/indra/llui/llview.cpp(767)
SecondLifeViewer!LLView::childrenHandleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1192)
SecondLifeViewer!LLView::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1138)
SecondLifeViewer!LLUICtrl::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/lluictrl.cpp(388)
SecondLifeViewer!LLFloater::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/llfloater.cpp(1722)
SecondLifeViewer!LLView::childrenHandleMouseEvent	C:/a/viewer/viewer/indra/llui/llview.cpp(767)
SecondLifeViewer!LLView::childrenHandleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1192)
SecondLifeViewer!LLView::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1138)
SecondLifeViewer!LLUICtrl::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/lluictrl.cpp(388)
SecondLifeViewer!LLView::childrenHandleMouseEvent	C:/a/viewer/viewer/indra/llui/llview.cpp(767)
SecondLifeViewer!LLView::childrenHandleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1192)
SecondLifeViewer!LLView::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1138)
SecondLifeViewer!LLUICtrl::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/lluictrl.cpp(388)
SecondLifeViewer!LLView::childrenHandleMouseEvent	C:/a/viewer/viewer/indra/llui/llview.cpp(767)
SecondLifeViewer!LLView::childrenHandleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1192)
SecondLifeViewer!LLView::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1138)
SecondLifeViewer!LLView::childrenHandleMouseEvent	C:/a/viewer/viewer/indra/llui/llview.cpp(767)
SecondLifeViewer!LLView::childrenHandleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1192)
SecondLifeViewer!LLView::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1138)
SecondLifeViewer!LLUICtrl::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/lluictrl.cpp(388)
SecondLifeViewer!LLView::childrenHandleMouseEvent	C:/a/viewer/viewer/indra/llui/llview.cpp(767)
SecondLifeViewer!LLView::childrenHandleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1192)
SecondLifeViewer!LLView::handleRightMouseDown	C:/a/viewer/viewer/indra/llui/llview.cpp(1138)
SecondLifeViewer!LLMouseHandler::handleAnyMouseClick	C:/a/viewer/viewer/indra/llwindow/llmousehandler.cpp(38)
SecondLifeViewer!LLViewerWindow::handleAnyMouseClick	C:/a/viewer/viewer/indra/newview/llviewerwindow.cpp(1115)
SecondLifeViewer!LLViewerInput::handleMouse	C:/a/viewer/viewer/indra/newview/llviewerinput.cpp(1619)
SecondLifeViewer!LLViewerWindow::handleRightMouseDown	C:/a/viewer/viewer/indra/newview/llviewerwindow.cpp(1204)
SecondLifeViewer!LLWindowWin32::mainWindowProc::__l74::::operator()	C:/a/viewer/viewer/indra/llwindow/llwindowwin32.cpp(2718)
SecondLifeViewer!std::invoke	C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.44.35207/include/type_traits(1670)
SecondLifeViewer!std::_Func_impl_no_alloc<`LLWindowWin32::mainWindowProc'::`74'::,void>::_Do_call	C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.44.35207/include/functional(884)
SecondLifeViewer!std::_Func_class::operator()	C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.44.35207/include/functional(926)
SecondLifeViewer!LLWindowWin32::gatherInput	C:/a/viewer/viewer/indra/llwindow/llwindowwin32.cpp(2249)
SecondLifeViewer!LLAppViewer::doFrame	C:/a/viewer/viewer/indra/newview/llappviewer.cpp(1417)
SecondLifeViewer!LLAppViewer::frame	C:/a/viewer/viewer/indra/newview/llappviewer.cpp(1334)
SecondLifeViewer!wWinMain	C:/a/viewer/viewer/indra/newview/llappviewerwin32.cpp(507)
SecondLifeViewer!invoke_main	D:/a/_work/1/s/src/vctools/crt/vcstartup/src/startup/exe_common.inl(118)
SecondLifeViewer!__scrt_common_main_seh	D:/a/_work/1/s/src/vctools/crt/vcstartup/src/startup/exe_common.inl(288)
kernel32!BaseThreadInitThunk	-
ntdll!RtlUserThreadStart	-

---

This repo is using Opire - what does it mean? 👇

💵 Everyone can add rewards for this issue commenting /reward 100 (replace 100 with the amount).
🕵️‍♂️ If someone starts working on this issue to earn the rewards, they can comment /try to let everyone know!
🙌 And when they open the PR, they can comment /claim #4591 either in the PR description or in a PR's comment.

🪙 Also, everyone can tip any user commenting /tip 20 @sl-service-account (replace 20 with the amount, and @sl-service-account with the user to tip).

📖 If you want to learn more, check out our documentation.

[akleshchev]

Likely scenario: right click an item that isn't a link in an outfit folder (normally not possible, but there are some 'legacy' folders that contain items instead of links).

Code tried to retrive an items from an outfit link, but it failed. Either item didn't exist or it wasn't a link in the first place.

[calebrosia]

Proposed Test Plan by Copilot
Based on the implicated code in LLWearableItemsList's ContextMenu and the typical UI logic, here is a likely manual test plan to validate the bug fix and prevent regressions:

---

Manual Test Plan for LLWearableItemsList ContextMenu Changes

1. Basic Context Menu Smoke Test

   • Open the Wearable Items List in the viewer.
   • Right-click various items (clothing, attachments, body parts, gestures) and verify the context menu appears without crashing.

2. Menu Item Visibility/Enablement

   • Select single and multiple items of each wearable type (clothing, body part, attachment, gesture).
   • Verify only valid menu options are visible/enabled for each selection (e.g., "Wear", "Add", "Replace", "Edit", "Create New", "Show Original", "Take Off", "Detach").
   • For attachments not worn, "Attach to..." and "Attach to HUD..." should be visible; otherwise, hidden.
   • If no menu options are available for the selection, "--no options--" appears.

3. Edge Cases and Error Handling

   • Select invalid/non-wearable items and verify warning is logged and menu is handled gracefully.
   • Select items with missing inventory data (simulate missing or corrupt items) and confirm no crash occurs, and warnings are handled.
   • Select a mix of links and originals and verify correct menu options.

4. Functional Testing of Actions

   • Test "Wear" and "Add" options on unworn wearable items; ensure they are correctly enabled/disabled.
   • Test "Replace" when already worn.
   • Test "Edit" and "Create New" options for editable items; confirm actions succeed.
   • Test "Take Off" and "Detach" for worn clothing/attachments.
   • For favorite/unfavorite options, verify menu updates based on item state.

5. Bulk Selection

   • Select many items at once (using shift/control) and confirm menu logic correctly aggregates item states (worn/unworn/editable/etc.).
   • Test right-click with all selected items already worn/not worn.

6. Menu Labeling

   • Confirm dynamic menu labels (e.g., "Create new Shirt", "Create new Pants") reflect the correct wearable type.

7. Regression: Outfits Panel Integration

   • Right-click wearable items via the Outfits panel and verify context menu logic is consistent and stable.

8. Performance and Stability

   • Rapidly right-click multiple times and switch selections to check for memory leaks or crashes.

---

Note: Test should be performed on all supported viewer versions and platforms. Any crash, UI error, or unexpected menu state should be documented.

---

This plan is inferred from the code's logic for handling context menu visibility, enablement, and error cases in LLWearableItemsList::ContextMenu::updateItemsVisibility and related functions.

[calebrosia]

Passed QA based on testing proposal above. No crash observed on mac and win Second Life Release 7.2.2.17774206511 (64bit) as part of https://github.com/secondlife/iqa/issues/550