Skip to content

Invalid GLTF file crashes viewer #4315

Open
@AtlasLinden

Description

@AtlasLinden

Environment

Second Life Project 7.1.14.15976006598 (GLTF Mesh Import)

Description

Selecting the the following invalid GLTF file for upload crashes the viewer.
Test_001_Invalid.zip

When attempting to upload this file as a material, the following prompt is provided:
Image

This file does not crash Blender when attempting to import. Instead the following error message is given:
Bad glTF: json error: Expecting ',' delimiter: line 45 column 25 (char 1037)

Last lines of SecondLife.log before crashing:

WARNING # llui/llview.h(722) LLView::getChild : Making dummy class LLView named "preview_panel" in floater
INFO # newview/llfloatermodelpreview.cpp(1185) LLFloaterModelPreview::initDecompControls : Simplify Method - 
INFO # newview/llfloatermodelpreview.cpp(1185) LLFloaterModelPreview::initDecompControls : Retain% - 
INFO # newview/llfloatermodelpreview.cpp(1185) LLFloaterModelPreview::initDecompControls : Detail Scale - 
INFO # newview/llfloatermodelpreview.cpp(1185) LLFloaterModelPreview::initDecompControls : Combine Quality - 
INFO # newview/llfloatermodelpreview.cpp(1185) LLFloaterModelPreview::initDecompControls : Method - 
INFO # newview/llfloatermodelpreview.cpp(1185) LLFloaterModelPreview::initDecompControls : Decompose Quality - 
INFO # newview/llfloatermodelpreview.cpp(1185) LLFloaterModelPreview::initDecompControls : Close Holes (Slow) - 
INFO # newview/llfloatermodelpreview.cpp(1185) LLFloaterModelPreview::initDecompControls : Simplify Coplanar - 
WARNING # llui/llview.h(722) LLView::getChild : Making dummy class LLCheckBoxCtrl named "Simplify Coplanar" in Model Preview
INFO # newview/llfloatermodelpreview.cpp(1185) LLFloaterModelPreview::initDecompControls : Cosine% - 
INFO # llui/llfloater.cpp(658) LLFloater::openFloater : Opening floater Model Preview full path: /main_view/menu_stack/world_panel/Floater View/Model Preview
INFO # newview/llfloatermodeluploadbase.cpp(48) LLFloaterModelUploadBase::requestAgentUploadPermissions : class LLFloaterModelPreview::requestAgentUploadPermissions() requesting for upload model permissions from: https://simhost-08d93b3782f17c0a1.agni.secondlife.io:12043/cap/84f38da6-4662-e12c-51ec-00a31dd477c8

Note that this crash does not appear in Bugsplat.

Reproduction steps

Attempt to upload the provided gltf file

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions