Ambient lighting inside of reflection probes gets applied when a legacy sky is applied

[Geenz]

Environment

Second Life Test 7.1.12.250021625 (64bit)
Release Notes
Build Configuration RelWithDebInfo

You are at 77.4, 112.1, 30.7 in Avalon Aviary located at simhost-0bafefdd96f0a0b93.agni
SLURL: http://maps.secondlife.com/secondlife/Avalon%20Aviary/77/112/31
(global coordinates 252,749.0, 288,112.0, 30.7)
Second Life Preflight 2024-10-19.11413863173
Release Notes

CPU: AMD Ryzen 9 7945HX3D 16-Core Processor (4192.2 MHz)
Memory: 65536 MB
OS Version: Microsoft Windows 11 64-bit (Build 26100.2605)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: NVIDIA GeForce RTX 3090/PCIe/SSE2

Windows Graphics Driver Version: 32.0.15.6636
OpenGL Version: 4.6.0 NVIDIA 566.36

Window size: 2558x1360
Font Size Adjustment: 96pt
UI Scaling: 1
Draw distance: 128m
Bandwidth: 3000kbit/s
LOD factor: 1.5
Render quality: 4
Texture memory: 24576MB
Disk cache: Max size 1638.4 MB (66.7% used)

J2C Decoder Version: KDU v7.10.4
Audio Driver Version: OpenAL, version 1.1 ALSOFT 1.23.1 / OpenAL Community / OpenAL Soft: OpenAL Soft
Dullahan: 1.14.0.202408091639
CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54
Chromium: 118.0.5993.54
LibVLC Version: 3.0.21
Voice Server Version: Secondlife WebRTC Gateway

Packets Lost: 7/6,057 (0.1%)
January 02 2025 09:54:50

Description

Legacy skies still seem to use the probe ambiance despite not applying probe ambiance scale globally. This creates problems when there is no tonemapping or HDR, which can be seen in the attached screenshot.

The expected result is that no probe ambiance is applied when a legacy sky is being used.

Reproduction steps

1. Create a reflection probe.
2. Set the reflection probe ambiance to something high - such as 10.
3. Change to a legacy sky, such as legacy midday
4. Observe that the ambiance is still being multiplied from by the probe ambient scale.

[katerynamproductengine]

Passed QA.

Verified on the Second Life Release 7.1.12.12682568132 (64bit) on Win10/OSX in the scope of https://github.com/secondlife/iqa/issues/423.

[Geenz]

Ambient lighting should not be applied inside of reflection probes when a legacy sky is detected. The issue that was originally reported demonstrated a probe with an ambient lighting multiplier set extremely high, and a legacy sky being applied which was resulting in very broken behavior when the legacy sky was applied. We had previously made the decision to not apply ambient lighting in reflection probes, and this appeared to be a case where a box probe was applying ambient lighting erroneously. The resident who setup the probe simply made it more obvious with their specific tweaks to the probe.