Reduce config switches for meta output - #50
Merged
Rider-Linden merged 2 commits intoJan 20, 2026
Conversation
…ng and outputing it causes confusion Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Rider-Linden
approved these changes
Jan 20, 2026
Rider-Linden
left a comment
Rider-Linden
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Thanks.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates two related configuration switches for file meta information into a single switch, simplifying the configuration and eliminating user confusion. The feature both outputs meta information and uses it for file matching, so requiring two separate switches was redundant.
Changes:
- Removed
FileMetaInfoUseForMatchingconfig key and consolidated its functionality into the existingFileMetaInfoInOutputconfig key - Updated the single config switch to control both meta output generation and file matching behavior
- Minor code cleanup including trailing whitespace removal and unused parameter marking
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/interfaces/configinterface.ts | Removed the redundant FileMetaInfoUseForMatching config key from the enum |
| src/synchservice.ts | Updated file matching logic to use the consolidated FileMetaInfoInOutput config key |
| package.json | Removed the separate configuration entry and updated the description of the consolidated config to explain both behaviors |
| src/shared/luadefsgenerator.ts | Cleaned up trailing whitespace (formatting-only change) |
| src/shared/languagetransformer.ts | Marked unused parameter with underscore prefix and removed trailing whitespace |
| data/syntax_def_default.json | Removed trailing whitespace (formatting-only change) |
| "type": "boolean", | ||
| "default": false, | ||
| "description": "Wether the file matcher should use script meta info for matching file" | ||
| "description": "Wether the output script should include some meta information about the file, this info is also used to match file on next edit" |
There was a problem hiding this comment.
Spelling error: "Wether" should be "Whether"
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes one of the config switches for the meta output.
it required the other switch to work and causes confusion by being separated.