Switch from class to extern syntax for luau-lsp defs and move DetecteEvent #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dEvent to classes Signed-off-by: WolfGangS <flamin2k8@gmail.com>
Rider-Linden
approved these changes
Nov 19, 2025
Collaborator
Rider-Linden
left a comment
Rider-Linden
left a comment
There was a problem hiding this comment.
I'll go ahead and make the change in the viewer if you've not already submitted a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the generation of the
DetectedEventto use class style outputAnd also switches the definition file over to using
declare extern typeinstead ofdeclare classA further piece of work on the viewer is needed to complete this, as the viewer will still be outputting the
DetectedEventin type aliases. see secondlife/viewer#5015Resolves #3