Fix array indentation of pretty xml #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix indentation on closing element of arrays.
bennettgoble
commented
Apr 2, 2024
|
|
||
| self.assertEqual(output_xml.decode("utf8"), """<?xml version="1.0" ?> | ||
| <llsd> | ||
| <map> |
There was a problem hiding this comment.
This matches prior versions of LLSD: the starting element after <llsd> is not indented.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 89.66% 89.67% +0.01%
==========================================
Files 6 6
Lines 861 862 +1
==========================================
+ Hits 772 773 +1
Misses 89 89 ☔ View full report in Codecov by Sentry. |
bennettgoble
force-pushed
the
signal/fix-array-indent
branch
3 times, most recently
from
12573b9 to
3d68c44
Compare
Fix a missing EOL after </llsd> and add a roundtrip test of viewer autobuild xml.
bennettgoble
force-pushed
the
signal/fix-array-indent
branch
from
3d68c44 to
da987c9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix indentation on closing element of arrays and file EOL.
Closes #17