-
Notifications
You must be signed in to change notification settings - Fork 1
SRV-439 - performance optimizations for string handling in xml formatting #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
8df4f8e
SRV-439 - performance optimizations for string handling in xml format…
roxanneskelly 7f1b5ae
Build in python containers, so we can get 2.7
roxanneskelly e44367b
fix syntax error
roxanneskelly 437db6b
try a different form for containers
roxanneskelly c6ca424
test
roxanneskelly 18dfa77
Spacing change
roxanneskelly 2059a06
Another fix
roxanneskelly a7a9ca3
Sudo pip installs (in container)
roxanneskelly 58ee348
upgrade pip
roxanneskelly a844d05
Update scm version settings
roxanneskelly 5c6f302
Try alpine container
roxanneskelly 30808b4
Don't upgrade pip
roxanneskelly 21b1945
Don't use alpine
roxanneskelly f0e0082
Show tags
roxanneskelly 67712a2
what user are we running under?
roxanneskelly 4c2cfaf
Try sudo
roxanneskelly ab0c5f6
Do we have a .git
roxanneskelly 0f8cb0e
Possibly don't need action to install python
roxanneskelly 466bd57
show tags
roxanneskelly 95671ab
mark directory as safe
roxanneskelly e201ac4
try direct safe directory
roxanneskelly b573bf8
Make all directories safe
roxanneskelly fc959dc
more diagnostics
roxanneskelly f288dc6
more diagnostics
roxanneskelly d01b6ad
show current user
roxanneskelly 308045d
Try buster
roxanneskelly 8bf587e
try venv
roxanneskelly b8745bb
be more assertive
roxanneskelly 91431ae
Try again
roxanneskelly 5be2d14
venv didn't work
roxanneskelly f15fa8e
show directory
roxanneskelly 289459c
make root of git user root
roxanneskelly c5ea1f3
oopse
roxanneskelly d3c22a3
more diagnostics
roxanneskelly c6e1e8c
fixup setup
roxanneskelly 1994a95
cleanup
roxanneskelly 00a4c7d
Remove iterative xml parsing
roxanneskelly 95584f6
Improve test code coverage
roxanneskelly e00171d
SL-19707 throw an error if we exceed 200 depth in formatting or parsing
roxanneskelly 78601c0
SL-19707 - maximum parse depth is now 200
roxanneskelly 6586308
CR changes
roxanneskelly c5e41c8
CR fixes
roxanneskelly 2432466
CR fixes
roxanneskelly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,21 +13,23 @@ jobs: | |
matrix: | ||
python-version: ['2.7', '3.7', '3.8', '3.10'] | ||
runs-on: [ubuntu-latest] | ||
container: | ||
image: "python:${{ matrix.python-version }}-buster" | ||
env: | ||
PYTHON: ${{ matrix.python-version }} | ||
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 # fetch all history for setuptools_scm to be able to read tags | ||
|
||
- uses: actions/setup-python@v4 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Install python dependencies | ||
run: | | ||
pip install wheel build tox | ||
pip install .[dev] | ||
apt-get update | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The python container requires some jumping through hoops due to user account and git differences. |
||
apt-get -y install sudo | ||
pip install --upgrade pip | ||
sudo chown root . | ||
sudo -H pip install wheel build tox | ||
sudo -H pip install .[dev] | ||
|
||
- name: Determine pyenv | ||
id: pyenv | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because setup-python no longer supports 2.7 (as of June 19th,) even with previous renditions of setup-python (the underlying support was taken away,) we need to run the python build in a container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep