SL-18330: In XML formatter, avoid adding call stack depth. #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making
LLSDXMLFormatter._elt()
accept a lambda was a tricky way to minimizesource changes to existing
_elt()
calls in_ARRAY()
and_MAP()
. The trouble isthat that added function entries for each level of a deeply-nested LLSD
structure -- and with our users, we unfortunately do encounter deeply-nested
large inventories. Log observed
RecursionError
failures in AIS.Explicitly write out the individual sequence of calls in
_ARRAY()
,_MAP()
andthe top-level
_write()
, the only callers to pass lambdas to_elt()
.