Skip to content

SL-18330: Use new standalone llsd module instead of llbase.llsd. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

nat-goodspeed
Copy link
Contributor

Ongoing development has moved to standalone llsd instead of llbase.llsd. In particular, the new llsd.parse() has greatly improved ability to correctly parse the stdin stream from the viewer.

The new llsd.parse() has greatly improved ability to correctly parse the stdin
stream from the viewer.
@nat-goodspeed
Copy link
Contributor Author

n.b.

RuntimeError: The Poetry configuration is invalid:
        - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

Not an actual problem with this PR.

@nat-goodspeed
Copy link
Contributor Author

Merged the llsd PR, essential for this fix, but the pre-commit check is still busted due to invalid Poetry configuration -- not the code.

Copy link
Contributor

@simon-linden simon-linden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the most important one line commits I've seen in a while - nice to have that self-contained!

@bennettgoble
Copy link
Member

bennettgoble commented Mar 14, 2023

@nat-goodspeed I suspect the pre-commit action is failing due to a cached dependency conflicting with a newer version of python that is getting pulled in by pre-commit.yaml's setup-python step. You could pin the python version used to the last CI run of pre-commit that passed, 3.11.1 to possibly solve the CI issue without disabling linting/tests. (See latest comment)

@bennettgoble
Copy link
Member

My previous suggestion is not correct, it looks like one of the linters specified in the pre-commit-config had an incompatibility with the latest version of poetry. Fixed in #15. Once this is merged, rebase and things should be good.

Copy link
Member

@bennettgoble bennettgoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires #15

@nat-goodspeed
Copy link
Contributor Author

Closing: I'll resubmit without the flailing commits attempting to disable the pre-commit check.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants