-
Notifications
You must be signed in to change notification settings - Fork 2
SL-18330: Use new standalone llsd module instead of llbase.llsd. #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The new llsd.parse() has greatly improved ability to correctly parse the stdin stream from the viewer.
n.b.
Not an actual problem with this PR. |
Merged the llsd PR, essential for this fix, but the pre-commit check is still busted due to invalid Poetry configuration -- not the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the most important one line commits I've seen in a while - nice to have that self-contained!
|
My previous suggestion is not correct, it looks like one of the linters specified in the pre-commit-config had an incompatibility with the latest version of poetry. Fixed in #15. Once this is merged, rebase and things should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires #15
Closing: I'll resubmit without the flailing commits attempting to disable the pre-commit check. |
Ongoing development has moved to standalone llsd instead of llbase.llsd. In particular, the new llsd.parse() has greatly improved ability to correctly parse the stdin stream from the viewer.