Skip to content

Use abs path for entrypoint and make it executable #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

jprendes
Copy link
Contributor

Recent versions of containerd-shim-wasmedge-v1 require that the wasm file be executable and resolvable using PATH.

Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Copy link
Member

juntao commented Aug 22, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit b1ebb29a457ebedb64d10dca5033c9a7de81615d

Key changes:

  • Used an absolute path ("/order_demo_service.wasm") for the entrypoint instead of just the file name ("order_demo_service.wasm").
  • Made the "order_demo_service.wasm" file executable by adding the command "RUN chmod a+x order_demo_service.wasm".
  • Added a line to copy the "order_demo_service.wasm" file from the build stage to the final image.

Potential problems:

  • It is unclear if the path "/root/.wasmedge/bin/wasmedgec" is valid and accessible. If this path is incorrect or the binary is missing, the build process might fail.
  • There might be a potential issue with the "RUN chmod a+x order_demo_service.wasm" command. It assumes that the "order_demo_service.wasm" file is located in the same directory where the Dockerfile is located. If the file is in a different directory, this command will fail and the image will not be built correctly.

Copy link
Member

@hydai hydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@hydai hydai merged commit 5d361ce into second-state:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants