Update Dockerfile #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #0 2.063 error: package `time-core v0.1.1` cannot be built because it requires rustc 1.65.0 or newer, while the currently active rustc version is 1.64.0
|
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Commit 6a2d89383564b665537767cefe93b34cc832d564The patch updates the Dockerfile's base image from rust:1.64 to rust:1.69. The reason for this change is because package One potential problem could be that any code that relies on features of rustc 1.64.0 that have been removed or changed in rustc 1.69 may fail to build or work properly. However, without more information about the project, it is impossible to evaluate the impact of this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested fix for following error, new to docker but my impression is that this should work
#0 2.063 error: package
time-core v0.1.1cannot be built because it requires rustc 1.65.0 or newer, while the currently active rustc version is 1.64.0Taken from their official image page on docker hub,
https://hub.docker.com/_/rust
https://github.com/rust-lang/docker-rust/tree/35579d26bda862c00d127d63cee4ab9cd5d114c2/1.69.0