Skip to content

Conversation

@gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Mar 23, 2024

This PR:

@gpotter2 gpotter2 added this to the 2.6.0 milestone Mar 23, 2024
@codecov
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Merging #4332 (4e5bdc8) into master (d8d24da) will increase coverage by 0.04%.
Report is 14 commits behind head on master.
The diff coverage is 85.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4332      +/-   ##
==========================================
+ Coverage   82.01%   82.05%   +0.04%     
==========================================
  Files         350      350              
  Lines       82225    82894     +669     
==========================================
+ Hits        67440    68022     +582     
- Misses      14785    14872      +87     
Files Coverage Δ
scapy/contrib/mpls.py 93.18% <100.00%> (+0.32%) ⬆️
scapy/fields.py 92.39% <100.00%> (+<0.01%) ⬆️
scapy/layers/inet6.py 88.68% <100.00%> (+0.01%) ⬆️
scapy/utils.py 73.09% <100.00%> (-1.99%) ⬇️
scapy/contrib/icmp_extensions.py 0.00% <0.00%> (-50.59%) ⬇️
scapy/layers/inet.py 71.63% <87.50%> (+1.04%) ⬆️

... and 27 files with indirect coverage changes

@gpotter2
Copy link
Member Author

gpotter2 commented Apr 1, 2024

@guedou @p-l- @polybassa This is ready for review & merge.

@guedou
Copy link
Member

guedou commented Apr 6, 2024

@gpotter2 do you want that the reporters of the issues confirm that this PR fix them? If not, this is ready to be merged.

@gpotter2 gpotter2 merged commit 0f4ded3 into secdev:master Apr 10, 2024
@gpotter2 gpotter2 deleted the icmp-extensions branch April 10, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICMP Extension Header wrong padding placement Wrong checksum calculation for Icmp Extension Header

2 participants