[Hinty] Type hinting: core - Windows#2163
Closed
gpotter2 wants to merge 3 commits intosecdev:masterfrom
gpotter2:mypy-1
Closed
[Hinty] Type hinting: core - Windows#2163gpotter2 wants to merge 3 commits intosecdev:masterfrom gpotter2:mypy-1
gpotter2 wants to merge 3 commits intosecdev:masterfrom
gpotter2:mypy-1
Conversation
gpotter2
commented
Jul 22, 2019
Member
Author
gpotter2
left a comment
gpotter2
left a comment
There was a problem hiding this comment.
A first example of what the review should look like
gpotter2
commented
Jul 22, 2019
gpotter2
changed the title
gpotter2
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2163 +/- ##
==========================================
- Coverage 87.34% 86.73% -0.62%
==========================================
Files 200 199 -1
Lines 45451 45455 +4
==========================================
- Hits 39699 39424 -275
- Misses 5752 6031 +279
|
Member
Author
|
Yeah this PR is ridiculous |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: after some experiments, Mypy will require so many changes that the files should be done one by one
Requires ##2162
This PR:
This was automatically generated, then reviewed manually. I may have missed some big mistakes, please review carefully. Note that the automatic detector tends to use specific Packet classes rather than the general "Packet" class.
Reviewers: it's a good idea to use the new "File viewed" feature 😄