RFE: clarify seccomp_rule_add syscall translation behavior #261
Conversation
Xyene
force-pushed
the
syscall-translation-docs
branch
from
38f9fa7
to
1cb5762
Compare
doc/man/man3/seccomp_rule_add.3
Outdated
| .B __NR_syscall | ||
| values in a context containing non-native architectures, the syscall | ||
| corresponding to the value in the native architecture will be used in all | ||
| non-native architectures. |
There was a problem hiding this comment.
I not sure that reads quite right, how about the following?
... it is highly recommended to use the SCMP_SYS() macro instead, see the EXAMPLES section below. It is also important to remember that regardless of the architectures present in the filter, the syscall numbers passed to the libseccomp rule add functions should always be in the context of the native architecture.
There was a problem hiding this comment.
@Xyene what did you think of the substitute text above?
There was a problem hiding this comment.
Sorry about the delay, I got DOS'd by real-life stuff -- I've committed a slightly reworded variant of your suggested text, emphasizing that libseccomp is performing some "interpreting" of the given syscall value.
pcmoore
changed the title
Xyene
force-pushed
the
syscall-translation-docs
branch
from
1cb5762
to
2215602
Compare
libseccomp performs a translation step when adding a raw syscall value to a multi-architecture filter. For instance, when adding __NR_open (syscall value 2 on x86-64) to a filter containing x86 and x86-64 where the native ABI is x86-64, the x86 BPF branch will use the value 5 (__NR_open on x86). This commit adds explicit documentation for the translation step. Refs seccomp#259. Signed-off-by: Tudor Brindus <me@tbrindus.ca>
Xyene
force-pushed
the
syscall-translation-docs
branch
from
2215602
to
3633794
Compare
|
Thanks for getting back to this, I definitely understand competing priorities and I can assure you we appreciate the help regardless of where libseccomp falls in your personal priority list :) This updated text looks good to me, any objections @drakenclimber? |
|
Looks good to me 👍
|
|
Merged via fa6264b, thanks! |
Refs #259.