Use python3 style super consistently #199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static syntax checker flagged layout_listbox_example.py at:
super(Gtk.ListBoxRow, self).init()
as:
bad-super-call: Bad first argument 'ListBoxRow' given to super()
This got me to check recent python3 situation.
https://docs.python.org/3.9/library/functions.html#super
https://rhettinger.wordpress.com/2011/05/26/super-considered-super/
After reading this and updating this part of code, I also realized all
subclass of Gtk.Window except one in popover_advanced_example.py were
not using super() but calling it directly in the subclass's init.
Not so nice.
I decided to fix them all for cleaner consistency.
Signed-off-by: Osamu Aoki osamu@debian.org