_get_balances_for_statement() method in CamtParser crashes when 'Cd' element missing in a 'Bal' element #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISO20022 specifies that a 'Type' element must contain either a 'Cd' element or a 'Prtry' element. Currently the method only looks for a 'Cd' element and crashes when it's missing. With my changes, the function looks for both 'Cd' and 'Prtry' elements in a 'Bal' element.
Also, when neither of the elements are found, the user is warned about the invalid element in the XML and the function continues. In that case, N/A is assigned as the type of the balance.I am not sure whether this is the best approach but it seemed more reasonable than exiting with an error. I am open to debate about this approach though.