Fix stack overflow in Deferred parsers with infinite recursion #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeferredandRecursiveparsers crash with stack overflow when configured with infinite recursion (e.g.,loop.Parser = looporRecursive(c => c)).Changes
ParseContext: Added position-aware cycle detection via
_activeParserPositionsHashSet tracking parser-position pairs using an optimized privateParserPositionrecord structIsParserActiveAtPosition(): Check if parser already active at current input offsetPushParserAtPosition()/PopParserAtPosition(): Manage active parser stackDisableLoopDetection: New property to disable loop detection when needed (e.g., when ParseContext is mutated during loops)Deferred.Parse(): Check for cycles before recursing; return
false(parse failure) when same parser invoked at same position. Respects theDisableLoopDetectionflag.Tests: Added coverage for direct self-reference, recursive constructor, valid recursion scenarios, and
DisableLoopDetectionflagValid recursive parsers that consume input between invocations remain unaffected. Loop detection can be disabled by setting
ParseContext.DisableLoopDetection = truewhen needed.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.