Skip to content

Guard parser expression compilation behind IsDynamicCodeSupported check #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

Guard parser expression compilation behind IsDynamicCodeSupported check #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Parlot/Fluent/Parser.TryParse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,17 @@ public abstract partial class Parser<T>

private Parser<T> CheckCompiled(ParseContext context)
{
#if NETSTANDARD2_1_OR_GREATER || NETCOREAPP3_0_OR_GREATER
if (!System.Runtime.CompilerServices.RuntimeFeature.IsDynamicCodeSupported)
{
// NativeAOT supports System.Linq.Expressions via an interpreter, but the parser compilation code path is
// fundamentally incompatible with trimming & AOT.
// Unless .Compile is explicitly called elsewhere, trim it (and the interpreter) from the build.
// See https://github.com/dotnet/runtime/blob/main/docs/design/tools/illink/feature-checks.md
return this;
}
#endif

if (_compiledParser != null || context.CompilationThreshold == 0)
{
return _compiledParser ?? this;
Expand Down