Refactor #7
Open
Refactor #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdewit
commented
Oct 27, 2014
jdewit
commented
- Allow inverted selection (false is true)
- Move hard coded styling to css
- move src files to src folder
- use uglify to minify
- add editorconfig file
…y; added grunt config and have it generate templates and minified js in /dest directory; updated README.md to include new info; added index-fa.html to demonstrate FontAwesome; bumped version to 0.4.0
remove templates in favor of configurable uiCheckbox constant
Fixed checkbox behaviour when using invert="true"
Owner
|
Thank you very much for your pull request but I am afraid I cannot get it to run at the current state. There seems to be a problem with your last merge and also it does not look right when opening the index.html, empty checkboxes are way too small. Could you please look into it? Additionally am missing the tpl files linked in the index*.html. |
|
I just took the .js and .css from this PR and it seems to run fine for me. |
Owner
|
Thank you very much for the hint. I promise I will look into it, as soon I have some spare time. It's very rare right now. |
- use render to update checked state - use ng-click to handle toggle - use font-awesome check/unchecked icon - minify css - remove unecessary styles - simply and clean up project structure - update readme & demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.