Support for regular expressions with #[IgnoreDeprecations] attribute
#6341
+155
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
ignore-deprecations-by-regex
branch
from
82e35f3 to
8a5c9a3
Compare
src/Metadata/IgnoreDeprecations.php
Outdated
| return true; | ||
| } | ||
|
|
||
| public function shouldIgnore(string $message): bool |
There was a problem hiding this comment.
I am not comfortable with the fact that a value object, which is what a Metadata object is supposed to be, makes a decision like that.
This decision should be moved to ErrorHandler::deprecationIgnoredByTest(), for example.
There was a problem hiding this comment.
done.
I must mention that I did the same thing in IgnorePhpunitWarnings: https://github.com/sebastianbergmann/phpunit/blob/main/src/Metadata/IgnorePhpunitWarnings.php#L40
do you want that I change that too?
There was a problem hiding this comment.
Yes, please. This should be a separate PR to the 12.3 branch. Thanks!
nikophil
force-pushed
the
ignore-deprecations-by-regex
branch
from
8a5c9a3 to
8ab4448
Compare
nikophil
force-pushed
the
ignore-deprecations-by-regex
branch
from
8ab4448 to
afea22c
Compare
sebastianbergmann
changed the title
#[IgnoreDeprecations]
sebastianbergmann
added
feature/test-runner
sebastianbergmann
changed the title
#[IgnoreDeprecations]#[IgnoreDeprecations] attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to only ignore specific deprecations, instead of all of them