Added shortcut to get a PHPUnit_Framework_Constraint_Count instance

[amenk]

No description provided.

[sebastianbergmann]

The name arrayCount() is wrong as objects that implement the Countable interface are also handled by PHPUnit_Framework_Constraint_Count.

[amenk]

Okay ... and suggestion for another name?

[edorian]

I don't really have a good idea. just count is not really pretty ether and hasExactlyElements($count) reads really ugly too

contains already has meaning.

Maybe something with size. ->with($this->size(5))-> could be readable. Not sure

[whatthejeff]

I like count as it's consistent with count(), assertCount(), Countable, PHPUnit_Framework_Constraint_Count, etc.

[havvg]

I won't use count as it would collide with \Countable if implemented on a sub class of PHPUnit_Framework_Assert.

How about counts or isCountOf, those comply with isEmpty, fileExists, stringContains etc.

[whatthejeff]

I won't use count as it would collide with \Countable if implemented on a sub class of PHPUnit_Framework_Assert.

Good point :)

How about counts or isCountOf, those comply with isEmpty, fileExists, stringContains etc.

What about countOf? I think that would be more readable when used with the fluent interface:

$stub->expects($this->once())
     ->method('bar')
     ->with($this->countOf(5));

[marijn]

countOf 👍

[whatthejeff]

Any update on this @havvg?

[whatthejeff]

I'm just going to merge this and call it countOf as there's been no response in 2 months.