Deprecation Triggers are not registered when process isolation is used #6017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When process isolation is used, the deprecation triggers are not registered on the ErrorHandler.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6017 +/- ##
=========================================
Coverage 94.73% 94.73%
Complexity 6439 6439
=========================================
Files 697 697
Lines 20252 20252
=========================================
Hits 19185 19185
Misses 1067 1067 ☔ View full report in Codecov by Sentry. |
|
@sebastianbergmann This one is ready. We first made sure the test was failing before applying our fix. Please have a look when you have time 🙏 |
sebastianbergmann
changed the title
|
Cherry-picked into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When process isolation is used, the deprecation triggers are not registered on the ErrorHandler.
Related to #5923