Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit events for E_* and E_USER_* triggered in data provider methods #5784

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Emit events for E_* and E_USER_* triggered in data provider methods #5784

wants to merge 16 commits into from

Conversation

sebastianbergmann
Copy link
Owner

No description provided.

@sebastianbergmann sebastianbergmann added type/enhancement A new idea that should be implemented feature/test-runner CLI test runner feature/data-provider Data Providers feature/events Issues related to PHPUnit's event system labels Mar 31, 2024
@sebastianbergmann sebastianbergmann mentioned this pull request Mar 31, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Mar 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.47619% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 89.39%. Comparing base (833fa23) to head (1a2a1f4).

Files Patch % Lines
src/Runner/ErrorHandler.php 88.88% 15 Missing ⚠️
src/Event/Emitter/DispatchingEmitter.php 86.66% 12 Missing ⚠️
...t/Exception/NoDataProviderOnCallStackException.php 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #5784      +/-   ##
============================================
+ Coverage     89.27%   89.39%   +0.12%     
- Complexity     6632     6763     +131     
============================================
  Files           697      707      +10     
  Lines         20033    20526     +493     
============================================
+ Hits          17885    18350     +465     
- Misses         2148     2176      +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann sebastianbergmann linked an issue Mar 31, 2024 that may be closed by this pull request
Emit events for E_* and E_USER_* triggered in data provider methods #5775
Open
@sebastianbergmann sebastianbergmann force-pushed the issue-5775/emit-events-for-errors-triggered-in-data-provider-methods branch 5 times, most recently from 1535c52 to b57159c Compare April 2, 2024 11:32
@sebastianbergmann sebastianbergmann mentioned this pull request Apr 2, 2024
Merged
@sebastianbergmann sebastianbergmann force-pushed the issue-5775/emit-events-for-errors-triggered-in-data-provider-methods branch 2 times, most recently from 98b6982 to c25e347 Compare April 13, 2024 06:41
@sebastianbergmann
Prepare error handler to be used in contexts other than test method e…
e726898 
…xecution (for instance data provider method execution for #5775)
@sebastianbergmann
Initial work on error handler context for data provider methods
ba172a6
@sebastianbergmann
Refactor
f520700
@sebastianbergmann
Add skeleton implementation for handling errors triggered in data pro…
9c73c5e 
…vider methods
@sebastianbergmann
Add DataProvider\MethodCalled and DataProvider\MethodFinished events …
2b87b12 
…(and deprecate Test\DataProviderMethodCalled and Test\DataProviderMethodFinished events)
@sebastianbergmann
Initial work on events for issues triggered during execution of data …
7ccfd90 
…provider methods
@sebastianbergmann
Refactor
1fd4b7f
@sebastianbergmann
Initial work on processing errors triggered during execution of data …
18432af 
…provider methods
@sebastianbergmann
Add test for data provider that triggers E_USER_DEPRECATED in its own…
02f6f0c 
… code
@sebastianbergmann
We need to be specific with disabling the error handler, too, as we h…
8d861b3 
…ave tests for the Data Provider API which acticate the error handler for both data provider methods and test methods
@sebastianbergmann
Import function
1fe7e75
@sebastianbergmann
Activate error handler for data provider methods
fa8b3c0
@sebastianbergmann
Mark test as expected to fail
41ef402
@sebastianbergmann
Add tests
16aa718
@sebastianbergmann
With 8d485f1, we no longer need to account for additional stack frame…
e01606c 
…s from ReflectionMethod::invoke()
@sebastianbergmann sebastianbergmann force-pushed the issue-5775/emit-events-for-errors-triggered-in-data-provider-methods branch from 8f2f74a to 1a2a1f4 Compare April 18, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature/data-provider Data Providers feature/events Issues related to PHPUnit's event system feature/test-runner CLI test runner type/enhancement A new idea that should be implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit events for E_* and E_USER_* triggered in data provider methods
1 participant
@sebastianbergmann