Skip to content

Remove Match interface #4374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2020
Merged

Remove Match interface #4374

merged 1 commit into from
Jul 10, 2020

Conversation

GrahamCampbell
Copy link
Contributor

From what I can see, this interface was not used, other than for defining ParameterMatch interface.

Closes #4373.

@codecov
Copy link

codecov bot commented Jul 10, 2020 •
edited
Loading

Codecov Report

Merging #4374 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4374   +/-   ##
=========================================
  Coverage     85.29%   85.29%           
  Complexity     4611     4611           
=========================================
  Files           219      219           
  Lines         12167    12167           
=========================================
  Hits          10378    10378           
  Misses         1789     1789

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a9b8c...6ea02ba. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit b57cd45 into sebastianbergmann:master Jul 10, 2020
@GrahamCampbell GrahamCampbell deleted the remove-match-interface branch July 10, 2020 14:12
@GrahamCampbell
Copy link
Contributor Author

🚀

@jdrieghe
Copy link

Would it be okay to merge this to the 9.2 branch and ship it in a release? The interface is not covered by the BC promise due to its internal nature and plenty of people are already running their CI suite against the latest releases of PHP 8.

@sebastianbergmann
Copy link
Owner

PHPUnit 9.2 is not supported on PHP 8, PHPUnit 9.3 will be.

@jdrieghe
Copy link

@sebastianbergmann understandable. According to your suggestion here (#4323 (comment)) we're already running it in CI, that's why I was asking. Not sure if that's enough of a reason to quickly backport this PR?

@jdrieghe
Copy link

Alternatively, we could always uese the latest master branch of phpunit to run the CI pipeline, but that also seems like a dangerous path to go down.

@GrahamCampbell
Copy link
Contributor Author

You can use ^9.3 for a version and in your composer.json, set minimum-stability dev and prefer-stable true. That way you will get 9.3.x dev versions until 9.3.0 is tagged, then stable versions from there on out.

@jdrieghe
Copy link

Thanks @GrahamCampbell. Never thought of that.

This was referenced Jul 15, 2020
Merged
Merged
This was referenced Jul 18, 2020
Merged
Merged
fabpot added a commit to symfony/symfony that referenced this pull request Jul 23, 2020
@fabpot
bug #37607 Fix checks for phpunit releases on Composer 2 (colinodell)
0eafc01 
This PR was merged into the 3.4 branch.

Discussion
----------

Fix checks for phpunit releases on Composer 2

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37601
| License       | MIT
| Doc PR        | n/a

`simple-phpunit` has a core assumption that any version of PHPUnit without a stable release will only have one dev version returned by Composer.  Per #37601, it's possible for Composer 2 to list **more than one dev version**.  This breaks that assumption and therefore prevents the installation of 9.3.* ([which is needed for testing on PHP 8](sebastianbergmann/phpunit#4374 (comment))).

The fix implemented here is to remove any versions containing `dev-` or `-dev` from the list of possible versions to see if any stable versions remain.

Commits
-------

2bb3f08 Fix checks for phpunit releases on Composer 2 (resolves #37601)
@LeSuisse LeSuisse mentioned this pull request Jul 23, 2020
Merged
@greg0ire greg0ire mentioned this pull request Jul 25, 2020
Merged
@Hackwar Hackwar mentioned this pull request Sep 9, 2020
Closed
@yookoala yookoala mentioned this pull request Jan 27, 2021
Closed
@htdat htdat mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"match" is a semi-reserved keyword in PHP 8
3 participants
@GrahamCampbell @jdrieghe @sebastianbergmann