-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to exit with exit code 1 when no tests are executed #4314
Merged
sebastianbergmann
merged 1 commit into
sebastianbergmann:master
from
localheinz:feature/fail-on-empty-test-suite
Jun 24, 2020
Merged
Add option to exit with exit code 1 when no tests are executed #4314
sebastianbergmann
merged 1 commit into
sebastianbergmann:master
from
localheinz:feature/fail-on-empty-test-suite
Jun 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4314 +/- ##
============================================
- Coverage 84.65% 84.60% -0.05%
- Complexity 4569 4579 +10
============================================
Files 257 257
Lines 11500 11520 +20
============================================
+ Hits 9735 9747 +12
- Misses 1765 1773 +8
Continue to review full report at Codecov.
|
4cc33c7
to
04b1b3b
Compare
Ayesh
reviewed
Jun 22, 2020
04b1b3b
to
99b3a65
Compare
99b3a65
to
6ee76f7
Compare
Thank you, @sebastianbergmann! |
This was referenced Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
failOnEmptyTestSuite
option which - when set - will fail a test run when no tests were foundFixes #4313.
πββοΈ I have tried adding an end-to-end test, but I'm unsure how to assert the exit code from a
.phpt
test. Is that even possible?Disabled
Enabled