Skip to content

Update AppVeyor build PHP versions #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2018

Conversation

mhujer
Copy link
Contributor

@mhujer mhujer commented Jan 27, 2018

@codecov-io
Copy link

codecov-io commented Jan 27, 2018

Codecov Report

Merging #2977 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2977   +/-   ##
=========================================
  Coverage     80.42%   80.42%           
  Complexity     2825     2825           
=========================================
  Files           107      107           
  Lines          7434     7434           
=========================================
  Hits           5979     5979           
  Misses         1455     1455

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49bf769...f124aa9. Read the comment docs.

@sebastianbergmann
Copy link
Owner

This makes me question the usefulness of AppVeyor. Maybe we should just remove it.

@mhujer
Copy link
Contributor Author

mhujer commented Jan 27, 2018

Or we can change links to point to http://windows.php.net/downloads/releases/archives/. There are all the older releases, so AppVeyor would run on a little bit older version, which should be fine.

@sebastianbergmann
Copy link
Owner

Using official binaries from windows.php.net sounds like a good idea.

@mhujer
Copy link
Contributor Author

mhujer commented Jan 27, 2018

I've updated the PR to use the new URL.

@sebastianbergmann sebastianbergmann merged commit e68aba2 into sebastianbergmann:master Jan 27, 2018
@mhujer mhujer deleted the mh-fix-appveyor branch January 27, 2018 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants