Fixes XML string escaping by removing invalid characters #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know this is really old, but while I was working on #832 I had a chance to review the code in this PR and it is indeed needed. I will merge this if you can rebase onto master. |
|
Closed by 1ea1e7f. |
|
Sorry, I didn't notice your reply. Is it still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are described in my commit note. I also added a test that checks all chars from 0 to 255 using DOMDocument::loadXML() - not sure how "standard" this implementation is, but for sure it is common in a PHP environment. Sorry for the delay.