Test with dependencies and data provider fails

[Justinas-Jurciukonis]

Q	A
PHPUnit version	11.1.3
PHP version	8.3.1
Installation Method	Composer

Summary

If test case has dependency on other test and has data provider, than it will fail to pass arguments with error

1) App\Tests\MyTest::testSomething with data set "DataSet1" (true, ['a', 'b'])
Error: Cannot use positional argument after named argument during unpacking

How to reproduce

Create following test case

    public function testOtherMethod(): void
    {
        ...

        return 'PREV_TEST';
    }

    #[Depends('testOtherMethod')]
    #[DataProviderExternal(MyTestDataProvider::class, 'getSomethingData')]
    public function testSomething(bool $expected, array $data, array $previousTestData): void
    {
    }

Thrown in PHPUnit\Framework\TestCase::runTest@1173

    final protected function runTest(): mixed
    {
        $testArguments = array_merge($this->data, array_values($this->dependencyInput)); // ['expected' => true, 'data' => ['a', 'b'], 0 => 'PREV_TEST'];

        try {
            $testResult = $this->{$this->methodName}(...$testArguments);
        } catch (Throwable $exception) {

Expected behavior

Test method is called correctly

Possible solution

Do not merge arguments to one array

    final protected function runTest(): mixed
    {
        try {
            $testResult = $this->{$this->methodName}(...$this->data, ...array_values($this->dependencyInput));
        } catch (Throwable $exception) {

[sebastianbergmann]

Thank you for your report.

Please provide a minimal, self-contained, reproducing test case that shows the problem you are reporting.

Without such a minimal, self-contained, reproducing test case I will not be able to investigate this issue.

[sebastianbergmann]

Did this work with PHPUnit 11.1.2 and now no longer works with PHPUnit 11.1.3?

[nepda]

In my case, this error occurs if the data provider method returns an array with a mixture of associative and non-associative arrays.

Example:

<?php declare(strict_types=1);

use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\TestCase;

final class DataProviderTestCase extends TestCase
{
   #[DataProvider('workingProvider')]
   public function testUseWorkingProvider(string $from, int $expected): void
   {
       $this->assertSame('january', $from);
       $this->assertSame(4, $expected);
   }

   public static function workingProvider(): array
   {
       return [
           [ 'from' => 'january', 'expected' => 4 ],
       ];
   }

   #[DataProvider('notWorkingProvider')]
   public function testUseNotWorking(string $from, int $expected): void
   {
       $this->assertSame('january', $from);
       $this->assertSame(4, $expected);
   }

   public static function notWorkingProvider(): array
   {
       return [
           [ 'from' => 'january', 4 ],
       ];
   }
}

My output:

PHPUnit 11.1.3 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.6

.E                                                                  2 / 2 (100%)

Time: 00:00.022, Memory: 4.00 MB

There was 1 error:

1) DataProviderTestCase::testUseNotWorking with data set #0 ('january', 4)
Error: Cannot use positional argument after named argument during unpacking

ERRORS!
Tests: 2, Assertions: 2, Errors: 1.
Failed to execute command php vendor/bin/phpunit TestCase.php: exit status 2

And for 11.1.2 it also doesn't work:

PHPUnit 11.1.2 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.6

.E                                                                  2 / 2 (100%)

Time: 00:00.014, Memory: 4.00 MB

There was 1 error:

1) DataProviderTestCase::testUseNotWorking with data set #0 ('january', 4)
Error: Cannot use positional argument after named argument during unpacking

ERRORS!
Tests: 2, Assertions: 2, Errors: 1.
Failed to execute command php vendor/bin/phpunit TestCase.php: exit status 2

[DaBonse]

Same here

Example:

<?php

namespace applicationTests;

use PHPUnit\Framework\TestCase;

class BugTest extends TestCase
{

    public function testOne()
    {
        $stdClass = new \stdClass();
        $stdClass->foo = 'bar';
        $this->assertIsObject($stdClass);
        return $stdClass;
    }


    #[\PHPUnit\Framework\Attributes\Depends('testOne')]
    #[\PHPUnit\Framework\Attributes\DataProvider('dataProvider')]
    public function testTwo(string $value1, string $value2, \stdClass $testOne)
    {
        // todo Test fails with: Error: Cannot use positional argument after named argument during unpacking
        $this->assertEmpty($value1);
        $this->assertEmpty($value2);
        $this->assertIsObject($testOne);
    }


    public static function dataProvider()
    {
        return [
            'value set one' => [
                'value1' => '',
                'value2' => '',
            ],
        ];
    }

}

Result:

PHPUnit 11.5.1 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.1

Error: Cannot use positional argument after named argument during unpacking
Time: 00:00.051, Memory: 4.00 MB

There was 1 error:

1) applicationTests\BugTest::testTwo with data set "value set one" ('', '')
Error: Cannot use positional argument after named argument during unpacking

ERRORS!
Tests: 2, Assertions: 1, Errors: 1.

Process finished with exit code 2

Test is working in PHPUnit 10.5.39

[sebastianbergmann]

if the data provider method returns an array with a mixture of associative and non-associative arrays

This is no longer supported due to the support for named arguments that was added in PHPUnit 11.0 with #5225.

[adimwiesem]

This was closed for a specific case ("mixture of associative and non-associative arrays") but the originally reported issue wasn't answered.

Here's a minimal example with two test functions. The second one depends on the first one and uses a data provider. Running the test yields this error:

1) dependencyTest::testTwo with data set "case 1" ('')
Error: Cannot use positional argument after named argument during unpacking

Code example:

<?php

class dependencyTest extends \PHPUnit\Framework\TestCase
{
    public function testOne(): void
    {
        $this->assertEmpty([]);
    }

    #[\PHPUnit\Framework\Attributes\Depends('testOne')]
    #[\PHPUnit\Framework\Attributes\DataProvider('dataProvider')]
    public function testTwo(string $example): void
    {
        $this->assertEmpty($example);
    }

    public static function dataProvider(): array
    {
        return [
            'case 1' => [
                'example' => ''
            ]
        ];
    }
}

I'd expect this to work because the data provider uses an associative array.
(Note: If I remove the dependency specification, the test runs successfully.)