Micro: cache Groups

sebastianbergmann · Mar 13, 2024 · cfbe088 · cfbe088
1 parent 59ad5c9
commit cfbe088
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/src/Metadata/Api/Groups.php b/src/Metadata/Api/Groups.php
@@ -10,6 +10,7 @@
 namespace PHPUnit\Metadata\Api;
 
 use function array_flip;
+use function array_key_exists;
 use function array_unique;
 use function assert;
 use function strtolower;
@@ -29,6 +30,11 @@
  */
 final class Groups
 {
+    /**
+     * @var array<string, list<string>>
+     */
+    private static array $groupCache = [];
+
     /**
      * @psalm-param class-string $className
      * @psalm-param non-empty-string $methodName
@@ -37,6 +43,12 @@ final class Groups
      */
     public function groups(string $className, string $methodName, bool $includeVirtual = true): array
     {
+        $key = $className . '::' . $methodName . '::' . $includeVirtual;
+
+        if (array_key_exists($key, self::$groupCache)) {
+            return self::$groupCache[$key];
+        }
+
         $groups = [];
 
         foreach (Registry::parser()->forClassAndMethod($className, $methodName)->isGroup() as $group) {
@@ -50,7 +62,7 @@ public function groups(string $className, string $methodName, bool $includeVirtu
         }
 
         if (!$includeVirtual) {
-            return array_unique($groups);
+            return self::$groupCache[$key] = array_unique($groups);
         }
 
         foreach (Registry::parser()->forClassAndMethod($className, $methodName) as $metadata) {
@@ -85,7 +97,7 @@ public function groups(string $className, string $methodName, bool $includeVirtu
             }
         }
 
-        return array_unique($groups);
+        return self::$groupCache[$key] = array_unique($groups);
     }
 
     /**