Favour assertSame() over assertEquals()

sebastianbergmann · Aug 3, 2023 · 6fd2727 · 6fd2727
1 parent 9f7422c
commit 6fd2727
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/Framework/TestCase.php b/src/Framework/TestCase.php
@@ -1956,7 +1956,7 @@ private function performAssertionsOnOutput(): void
             } elseif ($this->outputExpectedString !== null) {
                 assert(!empty($this->outputExpectedString));
 
-                $this->assertEquals($this->outputExpectedString, $this->output);
+                $this->assertSame($this->outputExpectedString, $this->output);
             }
         } catch (ExpectationFailedException $e) {
             $this->status = TestStatus::failure($e->getMessage());

diff --git a/tests/end-to-end/event/expectation-on-output.phpt b/tests/end-to-end/event/expectation-on-output.phpt
@@ -35,19 +35,19 @@ Test Runner Execution Started (3 tests)
 Test Suite Started (PHPUnit\TestFixture\Issue445Test, 3 tests)
 Test Preparation Started (PHPUnit\TestFixture\Issue445Test::testOutputWithExpectationBefore)
 Test Prepared (PHPUnit\TestFixture\Issue445Test::testOutputWithExpectationBefore)
-Assertion Succeeded (Constraint: is equal to 'test', Value: 'test')
+Assertion Succeeded (Constraint: is identical to 'test', Value: 'test')
 Test Passed (PHPUnit\TestFixture\Issue445Test::testOutputWithExpectationBefore)
 Test Finished (PHPUnit\TestFixture\Issue445Test::testOutputWithExpectationBefore)
 Test Preparation Started (PHPUnit\TestFixture\Issue445Test::testOutputWithExpectationAfter)
 Test Prepared (PHPUnit\TestFixture\Issue445Test::testOutputWithExpectationAfter)
-Assertion Succeeded (Constraint: is equal to 'test', Value: 'test')
+Assertion Succeeded (Constraint: is identical to 'test', Value: 'test')
 Test Passed (PHPUnit\TestFixture\Issue445Test::testOutputWithExpectationAfter)
 Test Finished (PHPUnit\TestFixture\Issue445Test::testOutputWithExpectationAfter)
 Test Preparation Started (PHPUnit\TestFixture\Issue445Test::testNotMatchingOutput)
 Test Prepared (PHPUnit\TestFixture\Issue445Test::testNotMatchingOutput)
-Assertion Failed (Constraint: is equal to 'foo', Value: 'bar')
+Assertion Failed (Constraint: is identical to 'foo', Value: 'bar')
 Test Failed (PHPUnit\TestFixture\Issue445Test::testNotMatchingOutput)
-Failed asserting that two strings are equal.
+Failed asserting that two strings are identical.
 Test Finished (PHPUnit\TestFixture\Issue445Test::testNotMatchingOutput)
 Test Suite Finished (PHPUnit\TestFixture\Issue445Test, 3 tests)
 Test Runner Execution Finished

diff --git a/tests/end-to-end/regression/433.phpt b/tests/end-to-end/regression/433.phpt
@@ -20,7 +20,7 @@ Time: %s, Memory: %s
 There was 1 failure:
 
 1) PHPUnit\TestFixture\Issue433Test::testNotMatchingOutput
-Failed asserting that two strings are equal.
+Failed asserting that two strings are identical.
 --- Expected
 +++ Actual
 @@ @@

diff --git a/tests/end-to-end/regression/445.phpt b/tests/end-to-end/regression/445.phpt
@@ -21,7 +21,7 @@ Time: %s, Memory: %s
 There was 1 failure:
 
 1) PHPUnit\TestFixture\Issue445Test::testNotMatchingOutput
-Failed asserting that two strings are equal.
+Failed asserting that two strings are identical.
 --- Expected
 +++ Actual
 @@ @@