Fix weak comparison between '0' and false
#99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
changed the title
0 and false'0' and false
mvorisek
changed the title
'0' and false'0' and false
|
@sebastianbergmann can you please merge this fix into 3.0 - 5.0 to fix phpunit 8.5 and 9.5? Github Actions CI should be probably backported to 3.0 branch too, but I run the tests and they are passing. |
| @@ -51,7 +51,7 @@ public function assertEquals($expected, $actual, $delta = 0.0, $canonicalize = f | |||
|
|
|||
| // always compare as strings to avoid strange behaviour | |||
There was a problem hiding this comment.
This behaviour exist since 9 years, changing it may be a BC break.
There was a problem hiding this comment.
that is true, but 0 equals false, so '0' must too, it is also the php behaviour of weak comparison
|
Thank you. Versions 3.0.4 and 4.0.7 have been tagged, sebastianbergmann/phpunit#4972 can be updated. |
SnakeCharm3r
pushed a commit
to SnakeCharm3r/comparator
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes sebastianbergmann/phpunit#4967