ScalarComparator does not handle extremely ugly string comparison edge cases
#58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parison edge cases Ref: https://twitter.com/malarzm/status/1006553195689201665 Ref: https://github.com/spaze/hashes Ref: https://3v4l.org/RXpfe Ref: https://3v4l.org/bDLUa Ref: https://3v4l.org/p1UgX Ref: Majkl578/php-src@578cc9e
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=========================================
Coverage 79.14% 79.14%
- Complexity 122 123 +1
=========================================
Files 15 15
Lines 326 326
=========================================
Hits 258 258
Misses 68 68
Continue to review full report at Codecov.
|
Ocramius
commented
Jun 14, 2018
| ['0.', '0.0', $stringException], | ||
| ['0e1', '0e2', $stringException], | ||
| ["\n\n\n0.0", ' 0.', $stringException], | ||
| ['0.0', '25e-10000', $stringException], |
There was a problem hiding this comment.
Can anyone here point at further scenarios that should be checked? Maybe string compared with non-string values?
sebastianbergmann
changed the title
ScalarComparator deals with extremely ugly string comparison edge casesScalarComparator does not handle extremely ugly string comparison edge cases
|
Thanks @sebastianbergmann! |
SnakeCharm3r
pushed a commit
to SnakeCharm3r/comparator
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://twitter.com/malarzm/status/1006553195689201665
Ref: https://github.com/spaze/hashes
Ref: https://3v4l.org/RXpfe
Ref: https://3v4l.org/bDLUa
Ref: https://3v4l.org/p1UgX
Ref: Majkl578/php-src@578cc9e