Add system calls numbers for aarch64 #142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
besser82
force-pushed
the
aarch64_syscalls
branch
from
9d00752 to
d2431fe
Compare
|
would love to see this merged! |
|
this patch is not correct. inotify_init is not the same as inotify_init1. this leaves whatever junk was previously in x0 as flags, which should always be 1 from PyArg_ParseTuple. kernel will return EINVAL if (flags&~(IN_NONBLOCK|IN_CLOEXEC)), and 1 is neither of those. therefore inotify will always fail. how did you test this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.