Add :disabled styles to buttons #110
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, setting a button as disabled only prevented the click handler from firing; it did not make any style changes. For the casual user, this presents as broken functionality rather than not-allowed functionality.
Loops through our VARIANT enum to render each style of button (including dupliacates) and shows the active and disabled styles side-by-side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The original button implementation had a disabled prop that prevented the onClick handler from being called, but did not include any stylistic changes to indicate to the user that the button was disabled. In fact the
:hoverand:activepseudo-classes were still being applied so it appeared as through the button was clicked but nothing was happening. This adds some additional style rules to the:disabledpseudo-class to provide visual cues to the user that the button is disabled.Types of changes
to change)
Checklist:
eslinton the codePriority:
Related Issues:
Fixes #109