Skip to content

[in progress] Have done fail test with error #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neall wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[in progress] Have done fail test with error #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f140dd1
reverse unless/else condition to be an if/else
neall Aug 11, 2015
b9b0f57
failing test for When's done called with an error
neall Aug 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/js/jasmine-given.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@
context = currentSpec
result = setupFunction.call(context, done)
if assignResultTo
unless context[assignResultTo]
context[assignResultTo] = result
else
if context[assignResultTo]
throw new Error("Unfortunately, the variable '#{assignResultTo}' is already assigned to: #{context[assignResultTo]}")
else
context[assignResultTo] = result

mostRecentExpectations = null
mostRecentStacks = null
Expand Down
11 changes: 11 additions & 0 deletions spec/implementation-spec.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,17 @@ describe "jasmine-given implementation", ->
expect(@then).not.toHaveBeenCalled()
expect(doneProvidedByJasmineRunner).not.toHaveBeenCalled()

context "the when calls its done() with an error", ->
beforeEach ->
When (done) -> done(new Error())
Then (done) -> @then(); done()
it '', ->
specImplementation = it.calls[0].args[1]
doneProvidedByJasmineRunner = jasmine.createSpy("done")
specImplementation(doneProvidedByJasmineRunner)
expect(@then).not.toHaveBeenCalled()
expect(doneProvidedByJasmineRunner).toHaveBeenCalled()

context "the when does indeed call its done()", ->
beforeEach ->
When (done) -> done()
Expand Down