-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add cart infering, update tracking documentation #1311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkonieczek
wants to merge
5
commits into
develop
Choose a base branch
from
cart-tracking
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+926
−1,297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces cart inference functionality in the tracker along with comprehensive updates to tracking documentation across multiple packages.
- Adds a new optional cart property to the tracker globals and processes cart updates in the tracker logic.
- Extends tests to validate cart inference behavior.
- Updates documentation for tracking events and context to align with the new cart and event structures.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
packages/snap-tracker/src/types.ts | Adds an optional cart array to the tracker globals and imports the Product type. |
packages/snap-tracker/src/Tracker.ts | Implements cart inference: comparing current vs. stored cart to trigger add/remove events and sends error notifications for invalid cart objects. |
packages/snap-tracker/src/Tracker.test.ts | Introduces tests covering various cart scenarios including empty carts, addition, removal, and error handling. |
packages/snap-preact/src/Snap.tsx | Merges cart data from shopper context into tracker globals and removes legacy cookie population. |
packages/snap-preact/src/Snap.test.tsx | Adjusts tests to validate tracker storage cart updates reflecting the new cart inference feature. |
docs/* and packages/snap-controller/* | Updates tracking documentation and event naming across multiple controllers and integration guides. |
packages/snap-controller/src/Autocomplete/AutocompleteController.ts
Outdated
Show resolved
Hide resolved
korgon
requested changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.