Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support interpolated string expression #94

Merged
merged 16 commits into from
Nov 24, 2023

Conversation

jeparlefrancais
Copy link
Contributor

@jeparlefrancais jeparlefrancais commented May 9, 2023

Closes #91

@ewd3v
Copy link

ewd3v commented Nov 1, 2023

@jeparlefrancais The issue Kampfkarren/full-moon#277 was fixed a couple of months ago, any possibility to continue on this pull request?

@jeparlefrancais
Copy link
Contributor Author

@jeparlefrancais The issue Kampfkarren/full-moon#277 was fixed a couple of months ago, any possibility to continue on this pull request?

There has not been any new release since the fix so I don't have a version to depend on yet 🙂 Soon I hope so!

@jeparlefrancais jeparlefrancais marked this pull request as ready for review November 23, 2023 19:57
Copy link

Coverage after merging interpolated-string-expression into main will be

86.99%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src
   ast_converter.rs88.46%100%90%88.38%1003, 1027, 1039, 1071, 1088, 1092–1095, 1109, 1128, 1148, 1163, 1188, 1205, 1226, 1245–1247, 1264, 1292, 1326, 1341, 1357–1359, 1369, 1374–1376, 1391, 1411, 1542–1544, 1605–1607, 1658–1660, 1684–1687, 1722–1724, 1752–1754, 1758–1760, 1820–1821, 1847–1849, 1856–1858, 1876–1878, 1902–1904, 1970, 1975–1977, 1997, 2003–2005, 2010–2012, 2040–2042, 2066, 2102, 212, 2120–2122, 213–214, 2146–2149, 2179–2181, 2192–2194, 2256–2258, 2270–2272, 2276–2278, 229–231, 2312, 2395–2397, 2425–2427, 2448–2450, 2480–2482, 2498, 2502, 2525–2527, 2539–2541, 2560–2562, 259–261, 2617–2619, 2650, 2682–2685, 2725–2729, 2773, 2966, 3042–3049, 3051–3058, 3060–3071, 3080, 3082–3087, 3090, 3115–3117, 3128–3130, 3147–3149, 478–480, 484–486, 594, 609–611, 646–648, 656, 670, 685–687, 691–693, 708–710, 714, 723–725, 766, 777–779, 785–787, 792–795, 806, 830, 917, 921–923
   parser.rs99.14%100%73.33%99.38%37, 43, 497–503, 55–59, 66
src/generator
   dense.rs86.96%100%90.22%86.65%1000–1002, 1019–1023, 1031, 1040–1041, 1046, 1052, 1061–1069, 1071–1077, 1079–1087, 1092, 1101, 1113–1116, 1120–1123, 147–148, 150, 164–165, 167, 241–253, 255–261, 263–264, 275–277, 356, 404, 494, 50–55, 57–59, 6, 601–603, 61–63, 65–67, 672, 68–69, 691, 882, 927, 944, 970–977, 996–999
   mod.rs98.69%100%100%98.58%354, 370, 374
   readable.rs97.20%100%95.33%97.37%1103, 1154–1158, 1209, 1306, 1316, 1325, 1334, 1343, 185–186, 191, 196, 214–215, 395, 46–51, 53, 58
   token_based.rs91.41%100%92.63%91.30%10, 1001–1002, 1016–1018, 1032–1034, 1043–1045, 1054–1056, 1065–1067, 1117–1121, 113, 1276, 130–131, 1346, 1383–1391, 1467–1469, 147, 1470–1476, 148, 1501–1503, 1505–1507, 1524–1533, 160–161, 1628, 182–183, 2025, 203–205, 2084–2085, 2111–2115, 2144–2148, 2155–2159, 2368, 2372, 2385, 245, 297–301, 371–372, 378, 390, 450–451, 473–474, 490–491, 533, 621–622, 655–656, 724–725, 766–767, 80, 808–812, 830–831, 84, 904–905, 914–915, 922, 937, 942–946, 965–966, 979–980
   utils.rs94.71%100%96.97%94.46%135, 30–31, 321, 33, 335–336, 35, 352–355, 59, 69, 79, 89
src/nodes/expressions
   binary.rs96.31%100%100%95.77%29, 56–58, 66–68, 70–72, 76–77, 86
   interpolated_string.rs77.98%100%72.60%79.53%126–129, 154–157, 188–191, 193, 221–223, 296–302, 333–338, 363–366, 66–69
   mod.rs77.78%100%78.05%77.71%134–136, 140–142, 146–148, 152–154, 158–160, 164–166, 182–184, 188–190, 266, 318–321, 323, 90–95
   prefix.rs68.75%100%75%66.67%24–27, 41, 60–62, 78–80
   string.rs96.31%100%93.55%96.96%49, 51, 94–96
   string_utils.rs81.01%100%64.71%82.72%100, 15–16, 168, 17–18, 196, 20–21, 24, 28–29, 3, 30–34, 9, 91–94, 97–99
src/nodes/types
   string_type.rs47.95%100%47.37%48.15%13–17, 46–48, 51–53, 56–58, 61–63, 66–68, 71–73, 81–83
   table.rs54.39%100%55.43%54.12%107–111, 136–138, 165–170, 172–177, 186–191, 236–238, 245–250, 252–257, 266–271, 282–286, 288, 290–294, 296, 306–310, 312, 340–348, 392–394, 406–410, 418–420, 447–454, 456–463, 474–481, 492–498, 500–506, 516–522, 57–60, 63–66, 75–78, 89–93, 95–99
   type_name.rs57.83%100%54.90%58.66%115–117, 130–132, 140–142, 155–158, 161–164, 173–176, 192–194, 210–212, 255–261, 263–269, 279–285, 33–34, 48–50, 67–72, 74–79, 91
src/process
   node_counter.rs66.67%100%66.67%66.67%38–40, 42–44, 54–56, 66–70, 72, 78–80
   node_processor.rs97.87%100%97.87%97.87%42
   visitors.rs99.08%100%100%98.98%88–93
src/process/evaluator
   mod.rs93.13%100%94.94%92.97%100–101, 162, 174, 179, 185, 196, 205–207, 213–215, 217–219, 221–222, 225, 237–239, 251–255, 259–260, 262–264, 304, 324, 338, 362, 365, 398, 404–405, 410, 424, 427, 445, 548, 58–60, 71, 784
src/rules
   remove_comments.rs70.80%100%67.21%71.83%159–161, 165–170, 172, 174, 176–178, 180–182, 184–186, 188–190, 192–194, 196–198, 200–202, 204–206, 208–210, 212–214, 216–218, 220–222, 224–226, 228–230, 77–79, 89
   remove_compound_assign.rs95.80%100%87.50%96.73%241–243, 53, 81
   remove_spaces.rs70.44%100%67.21%71.36%159–161, 165–170, 172, 174, 176–178, 180–182, 184–186, 188–190, 192–194, 196–198, 200–202, 204–206, 208–210, 212–214, 216–218, 220–222,

@jeparlefrancais jeparlefrancais merged commit f26c190 into main Nov 24, 2023
6 checks passed
@jeparlefrancais jeparlefrancais deleted the interpolated-string-expression branch November 24, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Luau interpolated strings
2 participants