Skip to content

chore(ci): make dependabot tell us of breaking changes we could upgrade to #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

seanmonstar
Copy link
Owner

I don't need dependabot telling me about very single point release. We purposefully keep the minimum range down, to allow people to use older versions of dependencies if they need it. There's a minimal-versions check for that even.

But this change should make it so we get notified when a dependency has a breaking change. That won't be automatically pulled in, but we probably want to upgrade to it. It's likely dependabot can't fix the breakage, but at least we'll be alerted that we should upgrade. And who knows, sometimes major release don't cause us any breakage at all!

@seanmonstar seanmonstar merged commit 5e03d04 into master May 29, 2025
37 checks passed
@seanmonstar seanmonstar deleted the dependabot-breaking-upgrades branch May 29, 2025 20:41
@Xuanwo
Copy link
Contributor

Xuanwo commented May 30, 2025

I have seen a warning message:

The property '#/updates/1/versioning-strategy' value "increase-if-necessary" did not match one of the following values: lockfile-only, auto

@seanmonstar
Copy link
Owner Author

Huh, I may have misread the docs about which ecosystems supported which strategies. Oh well, I can revert in the morning. It just sounded like a nice idea.

@seanmonstar
Copy link
Owner Author

@Xuanwo
Copy link
Contributor

Xuanwo commented May 30, 2025

Where did you see that warning? The source code suggests it is supported: https://github.com/dependabot/dependabot-core/blob/261436243d0fa5dc56e5010484ad6ba481dae098/cargo/lib/dependabot/cargo/update_checker/requirements_updater.rb#L30

There is a CI failure about this change: https://github.com/seanmonstar/reqwest/runs/43144541585

(And yes, I review every CI failure for reqwest! 😄)

@Xuanwo
Copy link
Contributor

Xuanwo commented May 30, 2025

The issue appears to remain unresolved since 2021: dependabot/dependabot-core#4009

@seanmonstar
Copy link
Owner Author

Yea I just found that issue too. Weird, I must not understand what that code that I linked to does, then.

@seanmonstar
Copy link
Owner Author

Ok, well I just reverted it in master, with a link to that issue. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants