-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP/3 panic if udp is not available #1942
Comments
The user run this in docker and errno 92 means protocol not available, meaning udp not available. |
Given that it's not unheard of for udp to be banned, and now it seems to be banned within docker, I think it's a good idea to make it "Option<>"nal. |
We should change it to return an error at least, instead of panic. An eventual feature improvement could allow falling back to other protocols, but only if someone configures they want to allow that; |
IMO fallback to other protocol should be the default, our user of cargo-binstall discovers this when running cargo-binstall inside docker and is probably blocked by the seccomp filer docker installed. Also many corp env do the same and block udp, so fallback should be the default unless turned off by http3_prior_knowledge. |
Fixed seanmonstar#1942 Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Fixed #1942 Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
From cargo-bins/cargo-binstall#1292 :
The text was updated successfully, but these errors were encountered: