Repository navigation
impl a function to parse chunk sizes - #12
Merged
Merged
Conversation
Owner
|
Excellent, I've been meaning to do something like this. I wonder if it makes sense to return |
All HTTP/1.1 clients and servers must understand the chunked encoding and therefore must parse chunk sizes. The `parse_chunk_size` function relies on the internals of httparse so it can't be implemented as easily in an external crate. It is based on hypers implementation but unlike hyper it operates on &[u8] and returns partial if the chunk size is incomplete. For this reason it is more suitable for async HTTP code.
Contributor
Author
|
It now uses |
seanmonstar
added a commit
that referenced
this pull request
Dec 7, 2015
impl a function to parse chunk sizes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All HTTP/1.1 clients and servers must understand the chunked encoding
and therefore must parse chunk sizes. The
parse_chunk_sizefunctionuses relies on the internals of httparse so it can't be implemented as
easily in an external crate. It is based on hypers implementation but
unlike hyper it operates on &[u8] and returns partial if the chunk size
is incomplete. For this reason it is more suitable for async HTTP code.
This is a breaking change because it adds a new variant to the Error
enum.