-
Notifications
You must be signed in to change notification settings - Fork 2
Initial Components: Device Details & Access Code Table #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting late here, so please excuse any typos or terse sounding comments. Mostly just trying to go-fast b/c such PR, much big. This is a great start! Some of the structure changes are great, but have some concerns about others. It's important we sort those out now as it will get harder to change our mind later about some of these conventions.
Side note on the CSS stuff: even without a bundler for |
Missed this on my first look, but +1 to this approach! |
Co-authored-by: Evan Sosenko <evan@getseam.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed on early merge with @seveibar and will have a follow up PR instead of blocking review.
Moved lots, renamed lots. Not saying we have to keep the changes, but it was just easier to show most of it rather than typing out, so here it is. I suppose this PR is more of an RFC, it's meant to be taken apart, so we can hopefully land on some consistent conventions going forward.
Style guide mostly follows the Airbnb style guide.
Run
npm run start
to see the components in storybookScreenshots
Other Notable things
/hooks/*
. Personally I find it easier to find things when they're named by use-case (vs. type). Here being able to browse the seam api by directory, and seeing the resources available is helpful.explicit-return
rule to let TS infer away.npm run build
each time to have it take effect.TS Error for MUI components: